Temporarily WAR rapidsmpf<->libcudf conda package build cycle (#22520) - #22772
Merged
Conversation
## Description Building the conda package of cudf-polars needs (for the smoketest) the _run_ dependencies, which include rapidsmpf. But rapidsmpf packages need libcudf conda packages so we have a cycle. Break that by removing the smoketest, and then we can figure out a proper solution. ## Checklist - [x] I am familiar with the [Contributing Guidelines](https://github.com/rapidsai/cudf/blob/HEAD/CONTRIBUTING.md). - [x] New or existing tests cover these changes. - [x] The documentation is up to date with these changes.
jolorunyomi
added
improvement
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe ChangesConda Recipe Test Disable
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@conda/recipes/cudf-polars/recipe.yaml`:
- Around line 52-61: The commented-out tests block removes package validation
permanently; uncomment it and instead of leaving it fully disabled add a clear
TODO guard comment above the tests block that states why it's temporarily
disabled, references a tracking issue (e.g., "TODO: re-enable tests - see
ISSUE-XXXX"), and specifies explicit re-enable criteria or date (e.g.,
"re-enable after RAPIDS/CUDF init fix or by YYYY-MM-DD"); ensure the top-level
tests block name ("tests") remains present and the TODO includes the tracking
issue ID and re-enable condition so maintainers can find and revert the
temporary change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: d4ff6ba4-588b-4412-b534-afb8b195920e
📒 Files selected for processing (1)
conda/recipes/cudf-polars/recipe.yaml
Comment on lines
+52
to
+61
| # tests: | ||
| # - python: | ||
| # imports: | ||
| # - cudf_polars | ||
| # pip_check: false | ||
| # - script: | ||
| # - python -c "import cudf_polars; print(cudf_polars.__version__)" | ||
| # - RAPIDS_NO_INITIALIZE=1 python -c "import cudf_polars; print(cudf_polars.__version__)" | ||
| # - CUDF_NO_INITIALIZE=1 python -c "import cudf_polars; print(cudf_polars.__version__)" | ||
| # - RAPIDS_NO_INITIALIZE=1 python -c "import cudf_polars; import polars as pl; print(pl.Series([1, 2, 3]))" |
There was a problem hiding this comment.
Add an explicit re-enable guard for this temporary test disable.
Commenting out the full tests block removes all package-level validation and can easily become permanent without a tracked rollback condition. Please annotate this block with a TODO + tracking issue and explicit re-enable criteria/date.
Suggested patch
-# tests:
+# TODO(https://github.com/rapidsai/cudf/issues/<issue-id>): Temporary WAR for
+# rapidsmpf<->libcudf conda build cycle. Re-enable recipe tests by 2026-07-31
+# (or once dependency cycle is resolved) to restore package validation.
+# tests:
# - python:
# imports:
# - cudf_polars
# pip_check: false🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@conda/recipes/cudf-polars/recipe.yaml` around lines 52 - 61, The
commented-out tests block removes package validation permanently; uncomment it
and instead of leaving it fully disabled add a clear TODO guard comment above
the tests block that states why it's temporarily disabled, references a tracking
issue (e.g., "TODO: re-enable tests - see ISSUE-XXXX"), and specifies explicit
re-enable criteria or date (e.g., "re-enable after RAPIDS/CUDF init fix or by
YYYY-MM-DD"); ensure the top-level tests block name ("tests") remains present
and the TODO includes the tracking issue ID and re-enable condition so
maintainers can find and revert the temporary change.
bdice
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry picked 7a1bb07